From 1dacfa49f06e2ca00e3765ede5c7db050fa34353 Mon Sep 17 00:00:00 2001
From: Marco Beretta <81851188+Berry-13@users.noreply.github.com>
Date: Thu, 17 Aug 2023 20:32:31 +0200
Subject: [PATCH] update profile picture (#792)

---
 api/strategies/discordStrategy.js | 12 +++++++-----
 api/strategies/githubStrategy.js  |  2 ++
 api/strategies/googleStrategy.js  |  2 ++
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/api/strategies/discordStrategy.js b/api/strategies/discordStrategy.js
index 685c81a47..3b4c1513d 100644
--- a/api/strategies/discordStrategy.js
+++ b/api/strategies/discordStrategy.js
@@ -17,11 +17,6 @@ const discordLogin = async () =>
         const email = profile.email;
         const discordId = profile.id;
 
-        const oldUser = await User.findOne({ email });
-        if (oldUser) {
-          return cb(null, oldUser);
-        }
-
         let avatarURL;
         if (profile.avatar) {
           const format = profile.avatar.startsWith('a_') ? 'gif' : 'png';
@@ -31,6 +26,13 @@ const discordLogin = async () =>
           avatarURL = `https://cdn.discordapp.com/embed/avatars/${defaultAvatarNum}.png`;
         }
 
+        const oldUser = await User.findOne({ email });
+        if (oldUser) {
+          oldUser.avatar = avatarURL;
+          await oldUser.save();
+          return cb(null, oldUser);
+        }
+
         const newUser = await User.create({
           provider: 'discord',
           discordId,
diff --git a/api/strategies/githubStrategy.js b/api/strategies/githubStrategy.js
index e021afbce..e663e92ca 100644
--- a/api/strategies/githubStrategy.js
+++ b/api/strategies/githubStrategy.js
@@ -23,6 +23,8 @@ const githubLogin = async () =>
 
         const oldUser = await User.findOne({ email });
         if (oldUser) {
+          oldUser.avatar = profile.photos[0].value;
+          await oldUser.save();
           return cb(null, oldUser);
         }
 
diff --git a/api/strategies/googleStrategy.js b/api/strategies/googleStrategy.js
index 7b02757e3..c44d2ef73 100644
--- a/api/strategies/googleStrategy.js
+++ b/api/strategies/googleStrategy.js
@@ -17,6 +17,8 @@ const googleLogin = async () =>
       try {
         const oldUser = await User.findOne({ email: profile.emails[0].value });
         if (oldUser) {
+          oldUser.avatar = profile.photos[0].value;
+          await oldUser.save();
           return cb(null, oldUser);
         }
       } catch (err) {