Files
LibreChat/client/src/hooks/Input/useQueryParams.spec.ts
“Praneeth 949682ef0f 🏪 feat: Agent Marketplace
bugfix: Enhance Agent and AgentCategory schemas with new fields for category, support contact, and promotion status

refactored and moved agent category methods and schema to data-schema package

🔧 fix: Merge and Rebase Conflicts

- Move AgentCategory from api/models to @packages/data-schemas structure
  - Add schema, types, methods, and model following codebase conventions
  - Implement auto-seeding of default categories during AppService startup
  - Update marketplace controller to use new data-schemas methods
  - Remove old model file and standalone seed script

refactor: unify agent marketplace to single endpoint with cursor pagination

  - Replace multiple marketplace routes with unified /marketplace endpoint
  - Add query string controls: category, search, limit, cursor, promoted, requiredPermission
  - Implement cursor-based pagination replacing page-based system
  - Integrate ACL permissions for proper access control
  - Fix ObjectId constructor error in Agent model
  - Update React components to use unified useGetMarketplaceAgentsQuery hook
  - Enhance type safety and remove deprecated useDynamicAgentQuery
  - Update tests for new marketplace architecture
  -Known issues:
  see more button after category switching + Unit tests

feat: add icon property to ProcessedAgentCategory interface

- Add useMarketplaceAgentsInfiniteQuery and useGetAgentCategoriesQuery to client/src/data-provider/Agents/
  - Replace manual pagination in AgentGrid with infinite query pattern
  - Update imports to use local data provider instead of librechat-data-provider
  - Add proper permission handling with PERMISSION_BITS.VIEW/EDIT constants
  - Improve agent access control by adding requiredPermission validation in backend
  - Remove manual cursor/state management in favor of infinite query built-ins
  - Maintain existing search and category filtering functionality

refactor: consolidate agent marketplace endpoints into main agents API and improve data management consistency

  - Remove dedicated marketplace controller and routes, merging functionality into main agents v1 API
  - Add countPromotedAgents function to Agent model for promoted agents count
  - Enhance getListAgents handler with marketplace filtering (category, search, promoted status)
  - Move getAgentCategories from marketplace to v1 controller with same functionality
  - Update agent mutations to invalidate marketplace queries and handle multiple permission levels
  - Improve cache management by updating all agent query variants (VIEW/EDIT permissions)
  - Consolidate agent data access patterns for better maintainability and consistency
  - Remove duplicate marketplace route definitions and middleware

selected view only agents injected in the drop down

fix: remove minlength validation for support contact name in agent schema

feat: add validation and error messages for agent name in AgentConfig and AgentPanel

fix: update agent permission check logic in AgentPanel to simplify condition

Fix linting WIP

Fix Unit tests WIP

ESLint fixes

eslint fix

refactor: enhance isDuplicateVersion function in Agent model for improved comparison logic

- Introduced handling for undefined/null values in array and object comparisons.
- Normalized array comparisons to treat undefined/null as empty arrays.
- Added deep comparison for objects and improved handling of primitive values.
- Enhanced projectIds comparison to ensure consistent MongoDB ObjectId handling.

refactor: remove redundant properties from IAgent interface in agent schema

chore: update localization for agent detail component and clean up imports

ci: update access middleware tests

chore: remove unused PermissionTypes import from Role model

ci: update AclEntry model tests

ci: update button accessibility labels in AgentDetail tests

refactor: update exhaustive dep. lint warning

🔧 fix: Fixed agent actions access

feat: Add role-level permissions for agent sharing people picker

  - Add PEOPLE_PICKER permission type with VIEW_USERS and VIEW_GROUPS permissions
  - Create custom middleware for query-aware permission validation
  - Implement permission-based type filtering in PeoplePicker component
  - Hide people picker UI when user lacks permissions, show only public toggle
  - Support granular access: users-only, groups-only, or mixed search modes

refactor: Replace marketplace interface config with permission-based system

  - Add MARKETPLACE permission type to handle marketplace access control
  - Update interface configuration to use role-based marketplace settings (admin/user)
  - Replace direct marketplace boolean config with permission-based checks
  - Modify frontend components to use marketplace permissions instead of interface config
  - Update agent query hooks to use marketplace permissions for determining permission levels
  - Add marketplace configuration structure similar to peoplePicker in YAML config
  - Backend now sets MARKETPLACE permissions based on interface configuration
  - When marketplace enabled: users get agents with EDIT permissions in dropdown lists  (builder mode)
  - When marketplace disabled: users get agents with VIEW permissions  in dropdown lists (browse mode)

🔧 fix: Redirect to New Chat if No Marketplace Access and Required Agent Name Placeholder (#8213)

* Fix: Fix the redirect to new chat page if access to marketplace is denied

* Fixed the required agent name placeholder

---------

Co-authored-by: Atef Bellaaj <slalom.bellaaj@external.daimlertruck.com>

chore: fix tests, remove unnecessary imports

refactor: Implement permission checks for file access via agents

- Updated `hasAccessToFilesViaAgent` to utilize permission checks for VIEW and EDIT access.
- Replaced project-based access validation with permission-based checks.
- Enhanced tests to cover new permission logic and ensure proper access control for files associated with agents.
- Cleaned up imports and initialized models in test files for consistency.

refactor: Enhance test setup and cleanup for file access control

- Introduced modelsToCleanup array to track models added during tests for proper cleanup.
- Updated afterAll hooks in test files to ensure all collections are cleared and only added models are deleted.
- Improved consistency in model initialization across test files.
- Added comments for clarity on cleanup processes and test data management.

chore: Update Jest configuration and test setup for improved timeout handling

- Added a global test timeout of 30 seconds in jest.config.js.
- Configured jest.setTimeout in jestSetup.js to allow individual test overrides if needed.
- Enhanced test reliability by ensuring consistent timeout settings across all tests.

refactor: Implement file access filtering based on agent permissions

- Introduced `filterFilesByAgentAccess` function to filter files based on user access through agents.
- Updated `getFiles` and `primeFiles` functions to utilize the new filtering logic.
- Moved `hasAccessToFilesViaAgent` function from the File model to permission services, adjusting imports accordingly
- Enhanced tests to ensure proper access control and filtering behavior for files associated with agents.

fix: make support_contact field a nested object rather than a sub-document

refactor: Update support_contact field initialization in agent model

- Removed handling for empty support_contact object in createAgent function.
- Changed default value of support_contact in agent schema to undefined.

test: Add comprehensive tests for support_contact field handling and versioning

refactor: remove unused avatar upload mutation field and add informational toast for success

chore: add missing SidePanelProvider for AgentMarketplace and organize imports

fix: resolve agent selection race condition in marketplace HandleStartChat
- Set agent in localStorage before newConversation to prevent useSelectorEffects from auto-selecting previous agent

fix: resolve agent dropdown showing raw ID instead of agent info from URL

  - Add proactive agent fetching when agent_id is present in URL parameters
  - Inject fetched agent into agents cache so dropdowns display proper name/avatar
  - Use useAgentsMap dependency to ensure proper cache initialization timing
  - Prevents raw agent IDs from showing in UI when visiting shared agent links

Fix: Agents endpoint renamed to "My Agent" for less confusion with the Marketplace agents.

chore: fix ESLint issues and Test Mocks

ci: update permissions structure in loadDefaultInterface tests

- Refactored permissions for MEMORY and added new permissions for MARKETPLACE and PEOPLE_PICKER.
- Ensured consistent structure for permissions across different types.

feat:  support_contact validation to allow empty email strings
2025-08-13 16:24:18 -04:00

532 lines
16 KiB
TypeScript

// useQueryParams.spec.ts
jest.mock('recoil', () => {
const originalModule = jest.requireActual('recoil');
return {
...originalModule,
atom: jest.fn().mockImplementation((config) => ({
key: config.key,
default: config.default,
})),
useRecoilValue: jest.fn(),
};
});
// Move mock store definition after the mocks
jest.mock('~/store', () => ({
modularChat: { key: 'modularChat', default: false },
availableTools: { key: 'availableTools', default: [] },
}));
import { renderHook, act } from '@testing-library/react';
import { useSearchParams } from 'react-router-dom';
import { useQueryClient } from '@tanstack/react-query';
import { useRecoilValue } from 'recoil';
import useQueryParams from './useQueryParams';
import { useChatContext, useChatFormContext } from '~/Providers';
import useSubmitMessage from '~/hooks/Messages/useSubmitMessage';
import useDefaultConvo from '~/hooks/Conversations/useDefaultConvo';
import store from '~/store';
// Other mocks
jest.mock('react-router-dom', () => ({
useSearchParams: jest.fn(),
}));
jest.mock('@tanstack/react-query', () => ({
useQueryClient: jest.fn(),
useQuery: jest.fn(),
}));
jest.mock('~/Providers', () => ({
useChatContext: jest.fn(),
useChatFormContext: jest.fn(),
}));
jest.mock('~/hooks/Messages/useSubmitMessage', () => ({
__esModule: true,
default: jest.fn(),
}));
jest.mock('~/hooks/Conversations/useDefaultConvo', () => ({
__esModule: true,
default: jest.fn(),
}));
jest.mock('~/hooks/AuthContext', () => ({
useAuthContext: jest.fn(),
}));
jest.mock('~/hooks/Agents/useAgentsMap', () => ({
__esModule: true,
default: jest.fn(() => ({})),
}));
jest.mock('~/utils', () => ({
getConvoSwitchLogic: jest.fn(() => ({
template: {},
shouldSwitch: false,
isNewModular: false,
newEndpointType: null,
isCurrentModular: false,
isExistingConversation: false,
})),
getModelSpecIconURL: jest.fn(() => 'icon-url'),
removeUnavailableTools: jest.fn((preset) => preset),
logger: { log: jest.fn() },
getInitialTheme: jest.fn(() => 'light'),
applyFontSize: jest.fn(),
}));
// Mock the tQueryParamsSchema
jest.mock('librechat-data-provider', () => ({
...jest.requireActual('librechat-data-provider'),
tQueryParamsSchema: {
shape: {
model: { parse: jest.fn((value) => value) },
endpoint: { parse: jest.fn((value) => value) },
temperature: { parse: jest.fn((value) => value) },
// Add other schema shapes as needed
},
},
isAgentsEndpoint: jest.fn(() => false),
isAssistantsEndpoint: jest.fn(() => false),
QueryKeys: { startupConfig: 'startupConfig', endpoints: 'endpoints' },
EModelEndpoint: { custom: 'custom', assistants: 'assistants', agents: 'agents' },
}));
// Mock data-provider hooks
jest.mock('~/data-provider', () => ({
useGetAgentByIdQuery: jest.fn(() => ({
data: null,
isLoading: false,
error: null,
})),
useAgentListingDefaultPermissionLevel: jest.fn(() => 'view'),
useListAgentsQuery: jest.fn(() => ({
data: null,
isLoading: false,
error: null,
})),
}));
// Mock global window.history
global.window = Object.create(window);
global.window.history = {
replaceState: jest.fn(),
pushState: jest.fn(),
go: jest.fn(),
back: jest.fn(),
forward: jest.fn(),
length: 1,
scrollRestoration: 'auto',
state: null,
};
describe('useQueryParams', () => {
// Setup common mocks before each test
beforeEach(() => {
jest.useFakeTimers();
// Reset mock for window.history.replaceState
jest.spyOn(window.history, 'replaceState').mockClear();
// Reset data-provider mocks
const dataProvider = jest.requireMock('~/data-provider');
(dataProvider.useGetAgentByIdQuery as jest.Mock).mockReturnValue({
data: null,
isLoading: false,
error: null,
});
// Create mocks for all dependencies
const mockSearchParams = new URLSearchParams();
(useSearchParams as jest.Mock).mockReturnValue([mockSearchParams, jest.fn()]);
const mockQueryClient = {
getQueryData: jest.fn().mockImplementation((key) => {
if (key === 'startupConfig') {
return { modelSpecs: { list: [] } };
}
if (key === 'endpoints') {
return {};
}
return null;
}),
};
(useQueryClient as jest.Mock).mockReturnValue(mockQueryClient);
(useRecoilValue as jest.Mock).mockImplementation((atom) => {
if (atom === store.modularChat) return false;
if (atom === store.availableTools) return [];
return null;
});
const mockConversation = { model: null, endpoint: null };
const mockNewConversation = jest.fn();
(useChatContext as jest.Mock).mockReturnValue({
conversation: mockConversation,
newConversation: mockNewConversation,
});
const mockMethods = {
setValue: jest.fn(),
getValues: jest.fn().mockReturnValue(''),
handleSubmit: jest.fn((callback) => () => callback({ text: 'test message' })),
};
(useChatFormContext as jest.Mock).mockReturnValue(mockMethods);
const mockSubmitMessage = jest.fn();
(useSubmitMessage as jest.Mock).mockReturnValue({
submitMessage: mockSubmitMessage,
});
const mockGetDefaultConversation = jest.fn().mockReturnValue({});
(useDefaultConvo as jest.Mock).mockReturnValue(mockGetDefaultConversation);
// Mock useAuthContext
const { useAuthContext } = jest.requireMock('~/hooks/AuthContext');
(useAuthContext as jest.Mock).mockReturnValue({
user: { id: 'test-user-id' },
isAuthenticated: true,
});
});
afterEach(() => {
jest.clearAllMocks();
jest.useRealTimers();
});
// Helper function to set URL parameters for testing
const setUrlParams = (params: Record<string, string>) => {
const searchParams = new URLSearchParams();
Object.entries(params).forEach(([key, value]) => {
searchParams.set(key, value);
});
(useSearchParams as jest.Mock).mockReturnValue([searchParams, jest.fn()]);
};
// Test cases remain the same
it('should process query parameters on initial render', () => {
// Setup
const mockSetValue = jest.fn();
const mockTextAreaRef = {
current: {
focus: jest.fn(),
setSelectionRange: jest.fn(),
} as unknown as HTMLTextAreaElement,
};
(useChatFormContext as jest.Mock).mockReturnValue({
setValue: mockSetValue,
getValues: jest.fn().mockReturnValue(''),
handleSubmit: jest.fn((callback) => () => callback({ text: 'test message' })),
});
// Mock startup config to allow processing
(useQueryClient as jest.Mock).mockReturnValue({
getQueryData: jest.fn().mockReturnValue({ modelSpecs: { list: [] } }),
});
setUrlParams({ q: 'hello world' });
// Execute
renderHook(() => useQueryParams({ textAreaRef: mockTextAreaRef }));
// Advance timer to trigger interval
act(() => {
jest.advanceTimersByTime(100);
});
// Assert
expect(mockSetValue).toHaveBeenCalledWith(
'text',
'hello world',
expect.objectContaining({ shouldValidate: true }),
);
expect(window.history.replaceState).toHaveBeenCalled();
});
it('should auto-submit message when submit=true and no settings to apply', () => {
// Setup
const mockSetValue = jest.fn();
const mockHandleSubmit = jest.fn((callback) => () => callback({ text: 'test message' }));
const mockSubmitMessage = jest.fn();
const mockTextAreaRef = {
current: {
focus: jest.fn(),
setSelectionRange: jest.fn(),
} as unknown as HTMLTextAreaElement,
};
(useChatFormContext as jest.Mock).mockReturnValue({
setValue: mockSetValue,
getValues: jest.fn().mockReturnValue(''),
handleSubmit: mockHandleSubmit,
});
(useSubmitMessage as jest.Mock).mockReturnValue({
submitMessage: mockSubmitMessage,
});
// Mock startup config to allow processing
(useQueryClient as jest.Mock).mockReturnValue({
getQueryData: jest.fn().mockReturnValue({ modelSpecs: { list: [] } }),
});
setUrlParams({ q: 'hello world', submit: 'true' });
// Execute
renderHook(() => useQueryParams({ textAreaRef: mockTextAreaRef }));
// Advance timer to trigger interval
act(() => {
jest.advanceTimersByTime(100);
});
// Assert
expect(mockSetValue).toHaveBeenCalledWith(
'text',
'hello world',
expect.objectContaining({ shouldValidate: true }),
);
expect(mockHandleSubmit).toHaveBeenCalled();
expect(mockSubmitMessage).toHaveBeenCalled();
});
it('should defer submission when settings need to be applied first', () => {
// Setup
const mockSetValue = jest.fn();
const mockHandleSubmit = jest.fn((callback) => () => callback({ text: 'test message' }));
const mockSubmitMessage = jest.fn();
const mockNewConversation = jest.fn();
const mockTextAreaRef = {
current: {
focus: jest.fn(),
setSelectionRange: jest.fn(),
} as unknown as HTMLTextAreaElement,
};
// Mock getQueryData to return array format for startupConfig
const mockGetQueryData = jest.fn().mockImplementation((key) => {
if (Array.isArray(key) && key[0] === 'startupConfig') {
return { modelSpecs: { list: [] } };
}
if (key === 'startupConfig') {
return { modelSpecs: { list: [] } };
}
return null;
});
(useChatFormContext as jest.Mock).mockReturnValue({
setValue: mockSetValue,
getValues: jest.fn().mockReturnValue(''),
handleSubmit: mockHandleSubmit,
});
(useSubmitMessage as jest.Mock).mockReturnValue({
submitMessage: mockSubmitMessage,
});
(useChatContext as jest.Mock).mockReturnValue({
conversation: { model: null, endpoint: null },
newConversation: mockNewConversation,
});
(useQueryClient as jest.Mock).mockReturnValue({
getQueryData: mockGetQueryData,
});
setUrlParams({ q: 'hello world', submit: 'true', model: 'gpt-4' });
// Execute
const { rerender } = renderHook(() => useQueryParams({ textAreaRef: mockTextAreaRef }));
// First interval tick should process params but not submit
act(() => {
jest.advanceTimersByTime(100);
});
// Assert initial state
expect(mockGetQueryData).toHaveBeenCalledWith(expect.anything());
expect(mockNewConversation).toHaveBeenCalled();
expect(mockSubmitMessage).not.toHaveBeenCalled(); // Not submitted yet
// Now mock conversation update to trigger settings application check
(useChatContext as jest.Mock).mockReturnValue({
conversation: { model: 'gpt-4', endpoint: null },
newConversation: mockNewConversation,
});
// Re-render to trigger the effect that watches for settings
rerender();
// Now the message should be submitted
expect(mockSetValue).toHaveBeenCalledWith(
'text',
'hello world',
expect.objectContaining({ shouldValidate: true }),
);
expect(mockHandleSubmit).toHaveBeenCalled();
expect(mockSubmitMessage).toHaveBeenCalled();
});
it('should submit after timeout if settings never get applied', () => {
// Setup
const mockSetValue = jest.fn();
const mockHandleSubmit = jest.fn((callback) => () => callback({ text: 'test message' }));
const mockSubmitMessage = jest.fn();
const mockNewConversation = jest.fn();
const mockTextAreaRef = {
current: {
focus: jest.fn(),
setSelectionRange: jest.fn(),
} as unknown as HTMLTextAreaElement,
};
(useChatFormContext as jest.Mock).mockReturnValue({
setValue: mockSetValue,
getValues: jest.fn().mockReturnValue(''),
handleSubmit: mockHandleSubmit,
});
(useSubmitMessage as jest.Mock).mockReturnValue({
submitMessage: mockSubmitMessage,
});
(useChatContext as jest.Mock).mockReturnValue({
conversation: { model: null, endpoint: null },
newConversation: mockNewConversation,
});
// Mock startup config to allow processing
(useQueryClient as jest.Mock).mockReturnValue({
getQueryData: jest.fn().mockImplementation((key) => {
if (Array.isArray(key) && key[0] === 'startupConfig') {
return { modelSpecs: { list: [] } };
}
if (key === 'startupConfig') {
return { modelSpecs: { list: [] } };
}
return null;
}),
});
setUrlParams({ q: 'hello world', submit: 'true', model: 'non-existent-model' });
// Execute
renderHook(() => useQueryParams({ textAreaRef: mockTextAreaRef }));
// First interval tick should process params but not submit
act(() => {
jest.advanceTimersByTime(100);
});
// Assert initial state
expect(mockSubmitMessage).not.toHaveBeenCalled(); // Not submitted yet
// Let the timeout happen naturally
act(() => {
// Advance timer to trigger the timeout in the hook
jest.advanceTimersByTime(3000); // MAX_SETTINGS_WAIT_MS
});
// Now the message should be submitted due to timeout
expect(mockSubmitMessage).toHaveBeenCalled();
});
it('should mark as submitted when no submit parameter is present', () => {
// Setup
const mockSetValue = jest.fn();
const mockHandleSubmit = jest.fn((callback) => () => callback({ text: 'test message' }));
const mockSubmitMessage = jest.fn();
const mockTextAreaRef = {
current: {
focus: jest.fn(),
setSelectionRange: jest.fn(),
} as unknown as HTMLTextAreaElement,
};
(useChatFormContext as jest.Mock).mockReturnValue({
setValue: mockSetValue,
getValues: jest.fn().mockReturnValue(''),
handleSubmit: mockHandleSubmit,
});
(useSubmitMessage as jest.Mock).mockReturnValue({
submitMessage: mockSubmitMessage,
});
// Mock startup config to allow processing
(useQueryClient as jest.Mock).mockReturnValue({
getQueryData: jest.fn().mockReturnValue({ modelSpecs: { list: [] } }),
});
setUrlParams({ model: 'gpt-4' }); // No submit=true
// Execute
renderHook(() => useQueryParams({ textAreaRef: mockTextAreaRef }));
// First interval tick should process params
act(() => {
jest.advanceTimersByTime(100);
});
// Assert initial state - submission should be marked as handled
expect(mockSubmitMessage).not.toHaveBeenCalled();
// Try to advance timer past the timeout
act(() => {
jest.advanceTimersByTime(4000);
});
// Submission still shouldn't happen
expect(mockSubmitMessage).not.toHaveBeenCalled();
});
it('should handle empty query parameters', () => {
// Setup
const mockSetValue = jest.fn();
const mockHandleSubmit = jest.fn();
const mockSubmitMessage = jest.fn();
// Force replaceState to be called
window.history.replaceState = jest.fn();
(useChatFormContext as jest.Mock).mockReturnValue({
setValue: mockSetValue,
getValues: jest.fn().mockReturnValue(''),
handleSubmit: mockHandleSubmit,
});
(useSubmitMessage as jest.Mock).mockReturnValue({
submitMessage: mockSubmitMessage,
});
// Mock startup config to allow processing
(useQueryClient as jest.Mock).mockReturnValue({
getQueryData: jest.fn().mockReturnValue({ modelSpecs: { list: [] } }),
});
setUrlParams({}); // Empty params
const mockTextAreaRef = {
current: {
focus: jest.fn(),
setSelectionRange: jest.fn(),
} as unknown as HTMLTextAreaElement,
};
// Execute
renderHook(() => useQueryParams({ textAreaRef: mockTextAreaRef }));
act(() => {
jest.advanceTimersByTime(100);
});
// Assert
expect(mockSetValue).not.toHaveBeenCalled();
expect(mockHandleSubmit).not.toHaveBeenCalled();
expect(mockSubmitMessage).not.toHaveBeenCalled();
expect(window.history.replaceState).toHaveBeenCalled();
});
});