vasceannie/supabase
1
0
Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity

fix: use vault functions for creating/updating secrets (#33337)

Browse Source
This commit is contained in:
Bobbie Soedirgo
2025-02-05 13:24:52 +08:00
committed by GitHub
parent 3be233f1e4
commit 02f7e75b4d
2 changed files with 20 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
apps/studio/data/vault/vault-secret-create-mutation.ts
View File

@@ -1,8 +1,8 @@
import { useMutation, UseMutationOptions, useQueryClient } from '@tanstack/react-query'
import { toast } from 'sonner'
import { Query } from 'components/grid/query/Query'
import { executeSql } from 'data/sql/execute-sql-query'
import { quoteLiteral } from 'lib/pg-format'
import type { ResponseError, VaultSecret } from 'types'
import { vaultSecretsKeys } from './keys'
@@ -17,10 +17,14 @@ export async function createVaultSecret({
...newSecret
}: VaultSecretCreateVariables) {
const { name, description, secret, key_id } = newSecret
const sql = new Query()
.from('secrets', 'vault')
.insert([{ name, description, secret, key_id }], { returning: true })
.toSql()
const sql = /* SQL */ `
select vault.create_secret(
new_secret := ${quoteLiteral(secret)}
${name ? `, new_name := ${quoteLiteral(name)}` : ''}
${description ? `, new_description := ${quoteLiteral(description)}` : ''}
${key_id ? `, new_key_id := ${quoteLiteral(key_id)}` : ''}
)
`
const { result } = await executeSql({ projectRef, connectionString, sql })
return result

17
apps/studio/data/vault/vault-secret-update-mutation.ts
View File

@@ -1,8 +1,8 @@
import { useMutation, UseMutationOptions, useQueryClient } from '@tanstack/react-query'
import { toast } from 'sonner'
import { Query } from 'components/grid/query/Query'
import { executeSql } from 'data/sql/execute-sql-query'
import { quoteLiteral } from 'lib/pg-format'
import type { ResponseError, VaultSecret } from 'types'
import { vaultSecretsKeys } from './keys'
@@ -18,11 +18,16 @@ export async function updateVaultSecret({
id,
...payload
}: VaultSecretUpdateVariables) {
const sql = new Query()
.from('decrypted_secrets', 'vault')
.update({ ...payload, updated_at: new Date().toISOString() }, { returning: true })
.match({ id })
.toSql()
const { name, description, secret, key_id } = payload
const sql = /* SQL */ `
select vault.update_secret(
secret_id := ${quoteLiteral(id)}
${secret ? `, new_secret := ${quoteLiteral(secret)}` : ''}
${name ? `, new_name := ${quoteLiteral(name)}` : ''}
${description ? `, new_description := ${quoteLiteral(description)}` : ''}
${key_id ? `, new_key_id := ${quoteLiteral(key_id)}` : ''}
)
`
const { result } = await executeSql({ projectRef, connectionString, sql })
return result